Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30277 )

Change subject: paging: Introduce BTS stat paging:request_queue_length
......................................................................


Patch Set 1:

(2 comments)

File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/8ff690b8_23eaf500
PS1, Line 92: to_be_deleted->bts
Why not paging_bts->bts_statg? I see it's used above.


https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/524780fa_6b8931f8
PS1, Line 470: bts
This is also confusing: above you're decrementing pending_requests_len via 
'bts_entry', but here you access the counters via 'bts'. Am I missing something?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6d296cdeba1392ef95fc31f6c04210c73f1b23e5
Gerrit-Change-Number: 30277
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 22 Nov 2022 18:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to