laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 )
Change subject: ttcn3-tcpdump-stop.sh: Don't use lsof
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Ah this was meant to be a reply to Max's comment, but it seems like replies
> cannot refer to specific […]
This doesn't change the fact that this patch had exactly *one* positive review
("Revieew +1") at the time you decided to simply set it to +2 and merge it.
This is not how the process works. You wait until somebody else has given a
single +2, or there are two other people having voted with +1 which you are
permitted to add to a +2:
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Code-Review-CR
Particularly for a new developer in the project, it is important to follow the
proces.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I38e132f49b0711d611d08b61c28b3092c991a191
Gerrit-Change-Number: 30313
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment
