Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )

Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................


Patch Set 1:

(3 comments)

Patchset:

PS1:
Looks good, just a few minor formatting issues.


File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/e89b384e_c08f6e33
PS1, Line 216:          page_ms(request);
spacing issues


https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/6f4069de_fb1f85d0
PS1, Line 279: static unsigned int step_page_retrans_reqs(struct 
gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, const 
struct timespec *now)
This line exceeds the 120 chars-per-line limit.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:39:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to