Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 )
Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371/comment/3f9f26cb_fce88b2f PS2, Line 1094: for (i := 0; i < 10; i := i + 1) { : f_rx_rlcmac_dl_block(dl_block, fn); : : if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { : /* Received first data, starting processing: */ : break; : } : } there seems to be a lot of copy+paste of this with the other 2 patches in this series. Wouldn't it make sense to have a function that does this? something like f_wait_for_rlcmac_dl_block_skip_dummy() or the like? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:54:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
