Attention is currently required from: laforge, pespin.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/30302 )

Change subject: rate_ctr: convert to timerfd
......................................................................


Patch Set 9:

(1 comment)

File src/rate_ctr.c:

https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/c9672742_59893d86
PS9, Line 358:  do { /* Increment number of ticks before we calculate intervals,
> I see no good reason to use do while here instead of just while, but ok...
Because it better expresses the expectations for the input to this part of the 
code: we expect and for the vast majority of cases (even on non-realtime 
kernel) get 1 == expire_count



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to