Patch Set 2: Code-Review+2 (6 comments)
Looks good except for these ideas, but don't bother to edit, I have the tweaks ready in an additional patch. Let's then just merge and fix the jobs in subsequent commits? https://gerrit.osmocom.org/#/c/4827/2/jobs/normal-builds.yml File jobs/normal-builds.yml: Line 2: # One cane simply add a gerrit job by adding project's repository to repos list. comment still says "gerrit builds" Line 12: a1_name: a1 I wish there was a better way than these static numbered axes. Because even if a job doesn't use them, the workspace is cluttered by a1-default/a2-default/a3-default/a4-default subdirs. Need to try out alternatives... Line 70: - osmo-gsm-tester_build-osmo-stp technical detail: the osmo-gsm-tester builds are downstream builds, yes, but we configured that with the osmo-gsm-tester builds: instead of telling libosmo-sccp to build osmo-gsm-tester_build-osmo-stp when done, we configure the osmo-gsm-tester_osmo-stp to build after libosmo-sccp. So that the master branch builds don't need to have any knowledge of osmo-gsm-tester. (same with osmo-ggsn below) Line 209: - osmo-mgw should rather be post-build triggers of osmo-iuh and osmo-mgw, like the others. Then we can also drop the pollscm here, and use the pollscm that is common to all other builds. Line 264: - '{repos}' I'd humbly propose that we call these jobs 'master-*'. It more accurately says what they build, and also we can install the jobs from this file next to the current, old ones, without overwriting them and thus we'll have an easy rollback path. The new ones can co-exist with the old ones until the new ones are verified to work, at which point we can drop the old ones. Line 313: - '*/master' IIUC the safest setting here is 'refs/remotes/origin/master', I'll give it a try -- To view, visit https://gerrit.osmocom.org/4827 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib04707393264a845876659d7bee0cdc9f8b897b6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
