Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30574 )
Change subject: gsm0808: add gsm0808_enc_speech_codec[_list]2() ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/30574/comment/83ad3ec4_657c8981 PS1, Line 315: return rc; > I thought about this too, but IMO trying to recover the given msgb would > unnecessary complicate thin […] Done https://gerrit.osmocom.org/c/libosmocore/+/30574/comment/e2269320_73f1b9a3 PS1, Line 434: old_tail = msg->tail; > same as above, "restore" msgb on error? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I199ffa0ba4a64813238519178155dfc767aa3975 Gerrit-Change-Number: 30574 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 22:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
