Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30566 )
Change subject: Move first_common_ts from gprs_rlcmac_tbf to GprsMs ...................................................................... Patch Set 2: (2 comments) File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/a8c4d44e_48d8c5b3 PS2, Line 67: simultaniously > I think "simultaneously" is somewhat misleading here, given that the UL and > DL TS have an offset and […] AFAICS, this comment is simply copied as-is from src/tbf.h#b223, except the value range. File src/pcu_vty_functions.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/44c459a2_dc14e822 PS2, Line 64: PRId8 Is there really a need for this change? %d would still work for int8_t, AFAIK. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8df01a99ccbfaf7a442ade5000ee282bd638fbba Gerrit-Change-Number: 30566 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 22:07:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
