Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30581 )
Change subject: gsm0808: add logging for some IE encoding errors ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It can still be used without having to initialize logging, as we do have a fallback mechanism: see #define LOGPSRCC and logp_stub(). > category DLGLOBAL is a bad fit, should we add DLBSSAP now? I don't think it's worth it. Be it good or bad, this is the only value we can use here ATM. > a solution would be an error_cb(), concise error info is provided by the lib, > the caller decides how to handle it. Too much complexity for... simply printing something that should not normally happen. IMHO. > should we also add logging and better handling for all other error cases in > this file? There are still plenty of assert()s in other enc_ functions waiting to be replaced ;) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758 Gerrit-Change-Number: 30581 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Tue, 13 Dec 2022 22:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
