Attention is currently required from: pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30588 )
Change subject: abis: Add a timeout while waiting for connect() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm a bit surprised with this approach? Why aren't we setting some sort of > connect timeout at socket […] I'm all for it but couldn't find what timeout to set. It didn't sound like SO_SNDTIMEO was really designed wo work with connect according to https://stackoverflow.com/questions/21783599/socket-so-sndtimeo-timout-is-double-the-set-value The other way that came to mind was add a timerfd that will abort the connect()? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b985d9ee472d5a39bc3da1dce1137ebabe93e85 Gerrit-Change-Number: 30588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 14 Dec 2022 14:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
