Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30575 )
Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch ...................................................................... Patch Set 2: (1 comment) File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/a4caaa93_8a0aae25 PS2, Line 68: _ts > How about renaming s/_ts/_pdch/ to make the type of this field cleaner? I thought about it already but I'm not sure it's really an improvement since the spec anyway talks about timeslots when explaining when/what is to be set, so having it named "ts" here also makes sense, I see no real need to change it (I'm not saying I'm against changing either, just that this is good enoguh so far). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89 Gerrit-Change-Number: 30575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 16 Dec 2022 11:07:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
