Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30620 )
Change subject: Convert tbf->control_ts to be a gprs_rlcmac_pdch* ...................................................................... Patch Set 2: (2 comments) File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/69110a5b_dbe74e5a PS2, Line 1316: ts == pdch Same here: comparing foo_ts to pdch may look confusing, so it's better to have a unified naming by doing s/_ts/_pdch/. File tests/alloc/AllocTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30620/comment/d1481da6_22451d8d PS2, Line 186: tbf->control_ts Maybe move NULL checking to pdch_name()? This way one could pass PDCH pointers directly without worrying if it's NULL. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a97b6528b2f9d78dfbca8fb97ab7c621f777fc7 Gerrit-Change-Number: 30620 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 15 Dec 2022 21:52:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
