Attention is currently required from: pespin, fixeria.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/30616 )

Change subject: ipa: Add ipa_client_conn_open2 with connect timeout argument
......................................................................


Patch Set 6:

(1 comment)

File src/input/ipa.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/d52044ce_aaad4dcc
PS5, Line 272:          /* Delete timer in case conn_open is called multiple 
times with different connect_timeout */
> This should not happen (called several times), the socket would be leaked too 
> then. […]
Good idea, will do that in a follow-up patch



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaeb672a4c981e9769443fb0cd6c8e59cb76307bd
Gerrit-Change-Number: 30616
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 15 Dec 2022 15:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to