Attention is currently required from: msuraev.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/30683 )

Change subject: SMPP: refactor ref counting code
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
I don't see the point of this patch. It's way clearer having a separate static 
function holding all the destroy code. My understanding is that fixeria also 
agrees with that?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30683
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9cb530991f54aa78edaa885f1242f63c705b6fcb
Gerrit-Change-Number: 30683
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Mon, 19 Dec 2022 10:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to