Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30685 )
Change subject: osmo_stream_srv_link_close(): properly handle NULL input ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not a big fan of this kind of null-return code paths for non-free > function, in general I think c […] I think library shouldn't suddenly crash it's user due to omitted NULL-check. Especially when it doesn'[t make call semanticallz incorrect. In general crashing the user app when library can avoid it requires additional debugging efforts and is unnecessary waste of time. See recent 5a513317292280aad8b9f81e1e1159153bd5ed4d in libosmocore for example. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie15bb3dc99bfe18065e03fde68d517b0d389b7ad Gerrit-Change-Number: 30685 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 16:16:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
