Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30686 )
Change subject: Add osmo_stream_srv_link_is_opened() ...................................................................... Patch Set 1: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30686/comment/10cb13cc_4e8db7f6 PS1, Line 1262: if (!link) > If at all OSMO_ASSERT() here. Why? The link is clearly unopened in this case. In general I'm not a big fan of needlessly crashing app using the library. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91aa7da5f09ec4e8e2d21c827b45ed92e6b0e3d9 Gerrit-Change-Number: 30686 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 16:18:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
