keith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/30699 )


Change subject: Vty: Add missing param to config write
......................................................................

Vty: Add missing param to config write

The mslookup client timeout parameter was not being written back
to the config.

This commit also add a define for the default timeout value.

Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
---
M include/osmocom/hlr/dgsm.h
M src/dgsm.c
M src/dgsm_vty.c
3 files changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/99/30699/1

diff --git a/include/osmocom/hlr/dgsm.h b/include/osmocom/hlr/dgsm.h
index cc8f3d2..1114fbe 100644
--- a/include/osmocom/hlr/dgsm.h
+++ b/include/osmocom/hlr/dgsm.h
@@ -25,6 +25,7 @@
 #include <osmocom/gsupclient/cni_peer_id.h>
 #include <osmocom/gsupclient/gsup_req.h>

+#define OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS    2000
 #define LOG_DGSM(imsi, level, fmt, args...) \
        LOGP(DDGSM, level, "(IMSI-%s) " fmt, imsi, ##args)

diff --git a/src/dgsm.c b/src/dgsm.c
index cdd82a2..f96bca6 100644
--- a/src/dgsm.c
+++ b/src/dgsm.c
@@ -170,7 +170,7 @@

        g_hlr->mslookup.server.local_attach_max_age = 60 * 60;

-       g_hlr->mslookup.client.result_timeout_milliseconds = 2000;
+       g_hlr->mslookup.client.result_timeout_milliseconds = 
OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS;

        g_hlr->gsup_unit_name.unit_name = "HLR";
        g_hlr->gsup_unit_name.serno = "unnamed-HLR";
diff --git a/src/dgsm_vty.c b/src/dgsm_vty.c
index 00a60ea..6598045 100644
--- a/src/dgsm_vty.c
+++ b/src/dgsm_vty.c
@@ -475,6 +475,10 @@
                        vty_out(vty, "  mdns domain-suffix %s%s",
                                g_hlr->mslookup.client.mdns.domain_suffix,
                                VTY_NEWLINE);
+               if (g_hlr->mslookup.client.result_timeout_milliseconds != 
OSMO_DGSM_DEFAULT_RESULT_TIMEOUT_MS)
+                       vty_out(vty, "  timeout %u%s",
+                               
g_hlr->mslookup.client.result_timeout_milliseconds,
+                               VTY_NEWLINE);
        }

        return CMD_SUCCESS;

--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibb60e74a0803f05f37ac13ca529d77b4cb736025
Gerrit-Change-Number: 30699
Gerrit-PatchSet: 1
Gerrit-Owner: keith <[email protected]>
Gerrit-MessageType: newchange

Reply via email to