Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30635 )
Change subject: cards: check length of mnc more restrictively ...................................................................... Patch Set 2: (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/30635/comment/88d269a8_c451a1e8 PS1, Line 213: raise RuntimeError('invalid length of mnc "{}"'.format(mnc)) > It would be handy to also print what exactly we consider valid length in here. I have updated that. In any case we shouldn't be able to reach this code path anyway since the code calling this should already made sure that the MNC is either 2 or 3 digits long. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iee8f25416e0cc3be96dff025affb1dc11d919fcd Gerrit-Change-Number: 30635 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 10:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
