Attention is currently required from: dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/30717 )

Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS3:
I wonder whether this really belongs to libosmo-abis, or rather to libosmo-gprs 
or osmo-pcu.


File include/osmocom/trau/trau_pcu_ericsson.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/e4f24a74_6395ced6
PS3, Line 219:  * frames and expects pcu_sync_ind frames from the PCU. When the 
CCU does not receive any pcu_sync_ind frames the CCU
"frames, the" (missing comma)


File src/trau/trau_pcu_ericsson.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ec3f2772_b38df17f
PS3, Line 252: static ubit_t calc_partity(const ubit_t *bits, size_t len)
typo: parity



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7
Gerrit-Change-Number: 30717
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 20 Dec 2022 14:52:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to