Attention is currently required from: laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 )
Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: (2 comments) File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/6ff617a5_cb97322a PS2, Line 71: #pragma GCC diagnostic push > I suppose so Done File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/f864ca37_e943a752 PS3, Line 110: int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port) > You missed calling _telnet_init_dynif() in here instead of duplicating code. yeah thanks for the heads up, noticed it looking at my patchset -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 15:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
