fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737 )
Change subject: library/L1CTL_Types: eliminate warning about missing 'h0h1' field ...................................................................... Patch Set 1: (1 comment) File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737/comment/c8ec2d87_272f71e9 PS1, Line 653: h0h1 := -, > And when you encode the template then it gives no problem later? Just willing > to understand/learn wh […] As you can see, this template is marked 'private'. It's a common base for both ts_L1CTL_DM_EST_REQ_H0 and ts_L1CTL_DM_EST_REQ_H1, which are built on top of it (note the 'modifies' keyword below). The point is to have common fields initialized in the base template and initialize the 'h0h1' field in the child templates. TITAN warned us that 'h0h1' is missing in the template definition, but this is intentional, so in this patch we explicitly tell it that this field should remain uninitialized. The '-' in TTCN-3 is a bit like the undefined in JavaScript. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73c86eea4708823e9c004a5b830793ce705dcb75 Gerrit-Change-Number: 30737 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 21 Dec 2022 14:47:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
