Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30766 )
Change subject: jenkins-common: tweak echo messages ...................................................................... Patch Set 1: (1 comment) File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/30766/comment/fc13b3b2_092d8462 PS1, Line 380: exit 1 > yo still want to add sed -x here so that the exit 1 is printed. why? the error message makes clear that it aborts and explains why. I think it's more useful to have that be the last line than "+ exit 1", just so it's easier to see this important message. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I213cb80bd1d9401281ae1fb7394b2319453550dd Gerrit-Change-Number: 30766 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 22 Dec 2022 15:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
