laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/30637
)
Change subject: pySim-prog: rename write_parameters function.
......................................................................
pySim-prog: rename write_parameters function.
The function name "write_parameters" is very generic and since it is
called during the programming cycle it should be made clear that it is
not about writing parameters to the card.
Change-Id: Idaba672987230d7d0dd500409f9fe0b94ba39370
---
M pySim-prog.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
msuraev: Looks good to me, but someone else must approve
diff --git a/pySim-prog.py b/pySim-prog.py
index dbf1148..f106018 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -669,7 +669,7 @@
conn.close()
-def write_parameters(opts, params):
+def write_parameters_to_csv_and_hlr(opts, params):
write_params_csv(opts, params)
write_params_hlr(opts, params)
@@ -764,8 +764,8 @@
else:
print("Dry Run: NOT PROGRAMMING!")
- # Write parameters permanently
- write_parameters(opts, cp)
+ # Write parameters to a specified CSV file or an HLR database (not the
card)
+ write_parameters_to_csv_and_hlr(opts, cp)
# Batch mode state update and save
if opts.num is not None:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/30637
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idaba672987230d7d0dd500409f9fe0b94ba39370
Gerrit-Change-Number: 30637
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-MessageType: merged
