Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30777 )
Change subject: mslookup: use apn functions from libosmocore ...................................................................... Patch Set 1: (2 comments) File src/mslookup/mdns_rfc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/30777/comment/d0fa1040_a41f19aa PS1, Line 80: if (osmo_apn_from_str(buf, buf_len, qst->domain) < 0) so in here you are assuming that encoding the string into the msg will take always exactly strlen(qst->domain) + 1. Is that correct to assume? https://gerrit.osmocom.org/c/osmo-hlr/+/30777/comment/d2f0bea4_e217b591 PS1, Line 105: ret->domain = talloc_size(ret, qname_len - 1); I'd expect the string to be longer than the buffer due to \0? Is this correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I09d3c617fd6eb4075084ee106d3f3c5803861d2f Gerrit-Change-Number: 30777 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 23 Dec 2022 13:00:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
