Attention is currently required from: neels, laforge.
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/30111 )

Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec
......................................................................


Patch Set 2: Verified-1

(1 comment)

File src/libmsc/sdp_msg.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2261):
https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/7a63cb4a_fe67dd12
PS2, Line 266:                             codec->rate > 0? codec->rate : 8000);
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30111
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d
Gerrit-Change-Number: 30111
Gerrit-PatchSet: 2
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 23 Dec 2022 14:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to