Attention is currently required from: daniel.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/30861 )

Change subject: Replace gprs_str_to_apn() with libosmocore API 
osmo_apn_from_str()
......................................................................


Patch Set 1:

(1 comment)

File tests/sgsn/sgsn_test.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/30861/comment/fe328c25_a1f7cb41
PS1, Line 40: #include <osmocom/sgsn/gprs_gmm_fsm.h>
> This looks like an incomplete alphabetical sort (vty should go to the bottom, 
> gsupclient in between  […]
Yes adding apn.h, but the whole block was so messed up that I moved stuff 
around.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30861
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d
Gerrit-Change-Number: 30861
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 04 Jan 2023 18:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to