Attention is currently required from: fixeria, pespin.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/30863 )

Change subject: bts: refuse to set invalid frame numbers
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS1:
> IMO, OSMO_ASSERT() would be enough as it gives enough context.
Done


File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30863/comment/be73830b_12e2d96b
PS1, Line 342: fn > GSM_TDMA_HYPERFRAME
> According to 3GPP TS 45.002, section 4.3. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iaae31b370fababba975d419b0d20ac15618c296e
Gerrit-Change-Number: 30863
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 05 Jan 2023 15:59:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to