Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/30877 )

Change subject: ctrl: error if program forgot to initialize the ctr handler 
before installing cmds
......................................................................


Patch Set 2:

(2 comments)

File src/ctrl/control_cmd.c:

https://gerrit.osmocom.org/c/libosmocore/+/30877/comment/cf239d75_d708ac71
PS2, Line 25: #include <asm-generic/errno-base.h>
Why including this header?


https://gerrit.osmocom.org/c/libosmocore/+/30877/comment/fefc2a06_2503f7fb
PS2, Line 215:  * the CTRL interface first by calling ctrl_handle_alloc(2)() 
directly
(Would be great if linter enforced the usual comment formatting)



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30877
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf3873f33470499fed3150ff51922a36aa0f023e
Gerrit-Change-Number: 30877
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 05 Jan 2023 16:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to