Patch Set 2: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/5008/2/src/osmo_gsm_tester/bts_octphy.py File src/osmo_gsm_tester/bts_octphy.py: Line 177: config.overlay(values, sgsn_conf) heh, why not if self.sgsn: config.overlay... -- To view, visit https://gerrit.osmocom.org/5008 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54780971d711d47b23976dd044a4a53134dd4299 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
