Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30831 )
Change subject: tunend: choose local GTP addr by Network Instance IEs ...................................................................... Patch Set 2: (2 comments) File src/osmo-upf/upf_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/30831/comment/3e6fe394_20aa0221 PS2, Line 156: " and GTPv0 port " OSMO_STRINGIFY_VAL(PORT_GTP0_U) " on the specified LISTEN_ADDR\n" > Ah I see you mention GTPv1 on top. […] I assume for osmo-upf GTPv0 is not interesting or required or intended. But gtp_dev_create() to make a GTP kernel device wants an fd0 argument https://gitea.osmocom.org/cellular-infrastructure/libgtpnl/src/branch/master/src/gtp-rtnl.c#L141 so GTPv0 crept into osmo-upf, halfheartedly https://gerrit.osmocom.org/c/osmo-upf/+/30831/comment/c1da57fd_289dc5d0 PS2, Line 159: " " drop (note to self) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I376c09bfc1844df1e61d2efac17561fac614858b Gerrit-Change-Number: 30831 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 23:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
