dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30894 )


Change subject: abis_rsl: add spec ref for frame number calculation
......................................................................

abis_rsl: add spec ref for frame number calculation

The frame number calculation in rsl_rx_pchan_rqd() is done using a
specific formula. Lets add a spec reference and also restructure the
code a bit.

Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/30894/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index bb1c5d6..51824f5 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1814,11 +1814,13 @@
                return -EINVAL;
        } else {
                is_11bit = 0;
+               rqd_ta = rqd->ta;
+
+               /* See also 3GPP TS 04.08, section 10.5.2.38 and 3GPP TS 08.58, 
section 9.3.8 */
                t1 = rqd->ref.t1;
                t2 = rqd->ref.t2;
                t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3);
                fn = (51 * ((t3-t2) % 26) + t3 + 51 * 26 * t1);
-               rqd_ta = rqd->ta;
        }

        return pcu_tx_rach_ind(rqd->bts, rqd_ta, rqd->ref.ra, fn, is_11bit,

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30894
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I60500c8694dbc2e6e2c4bbffd4ff7057bbc324e6
Gerrit-Change-Number: 30894
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-MessageType: newchange

Reply via email to