Attention is currently required from: pespin.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/30909 )

Change subject: vty: Introduce encryption cipher-plugin-path command
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/30909/comment/0abbba36_04f827d9
PS1, Line 12: cause internally if the path doesn't exist (unless NULL is 
passed).
This sentence reads a bit odd. "... which can cause internally" do you mean 
"... which can cause an internal error"?


Patchset:

PS1:
Looks good to me. I guess you are sure that it is no problem that there is no 
default path anymore?



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30909
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4f965c7afafa193f4d7486750dd3e43cca22bb65
Gerrit-Change-Number: 30909
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 10 Jan 2023 10:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to