Attention is currently required from: pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890 )
Change subject: gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance
......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gtp_ggsn.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890/comment/d08f4dfa_73af9c18
PS1, Line 38: extern void *tall_sgsn_ctx;
this is unsused.
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890/comment/a80f8616_f560832e
PS1, Line 66: ggc = talloc_zero(sgsn, struct sgsn_ggsn_ctx);
I'm unsure if it wouldn't be much better to add the sgsn parameter as it is
used in sgsn_mme_ctx_alloc()
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 10 Jan 2023 18:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
