dexter has submitted this change and it was merged.

Change subject: client: use string as connection identifier
......................................................................


client: use string as connection identifier

The test that tests the cancelation of a pending mgcp message
uses an integer as connection identifier, which leads to a
segfault since connection identifiers are represented as strings.

Use a string as connection identifier.

Change-Id: I395a23c1828cf216031d69d481ad35dd458ee7d4
---
M tests/mgcp_client/mgcp_client_test.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/mgcp_client/mgcp_client_test.c 
b/tests/mgcp_client/mgcp_client_test.c
index 172faac..ef2fca8 100644
--- a/tests/mgcp_client/mgcp_client_test.c
+++ b/tests/mgcp_client/mgcp_client_test.c
@@ -236,7 +236,7 @@
                .endpoint = "23@mgw",
                .audio_port = 1234,
                .call_id = 47,
-               .conn_id = 11,
+               .conn_id = "11",
                .conn_mode = MGCP_CONN_RECV_SEND,
                .presence = (MGCP_MSG_PRESENCE_ENDPOINT | 
MGCP_MSG_PRESENCE_CALL_ID
                             | MGCP_MSG_PRESENCE_CONN_ID | 
MGCP_MSG_PRESENCE_CONN_MODE),

-- 
To view, visit https://gerrit.osmocom.org/5167
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I395a23c1828cf216031d69d481ad35dd458ee7d4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: neels <[email protected]>

Reply via email to