Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30976 )
Change subject: mobile: settings.h: Add missing type forward declaration ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/include/osmocom/bb/mobile/settings.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30976/comment/a9614b94_f1ce01db PS1, Line 7: struct osmocom_ms; > Why is this necessary? Does the lack of it cause some compiler warning? It's necessary because osmocom_ms is used further below. It will cause compiler errors in followup comits when the way includes are imported change. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibdfa905e2bd24f03d23ce114e969647b07a2009f Gerrit-Change-Number: 30976 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Sat, 14 Jan 2023 19:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
