Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30979 )
Change subject: layer23: Let each app allocate its ms obj and start layer2 when needed ...................................................................... Patch Set 3: (2 comments) File src/host/layer23/src/misc/app_cell_log.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30979/comment/178cf469_05fe40ad PS3, Line 53: fprintf(stderr, "Failed during layer2_open()\n"); > It's better to print layer2_socket_path so user know what exactly failed to > open. […] Ack File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30979/comment/af67876a_0d6392d6 PS3, Line 476: rc = layer2_open(app_data.ms, app_data.ms->settings.layer2_socket_path); > This code is duplicated so many times that I can't help but wonder - why not > make shared error-print […] I see no need for it, it's a usuall function call + check + print + err. Moreover, some apps may use LOGP in there (some amms support osmo logging and some don't iirc). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32f99df76a5513eff9df5489d28d60aedf96dec3 Gerrit-Change-Number: 30979 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Sat, 14 Jan 2023 19:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
