Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5185/1/src/select.c File src/select.c: PS1, Line 326: ofd->fd < 0 this is the only controversial part: Do we force the user to initialize the unused ofd->fd to -1 and safely handle multiple successive calls to osmo_timerfd_setup(), OR do we work with normal zero-initialized structs, at which point "0" is a valid FD and we could not handle multiple calls to osmo_timerfd_setup() correctly. -- To view, visit https://gerrit.osmocom.org/5185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeffba7c997252c003723bcd5d14122c4ded2fe7 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
