Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30961 )
Change subject: layer23: Initial VTY framework to share VTY code between apps ...................................................................... Patch Set 9: (9 comments) File src/host/layer23/include/osmocom/bb/common/vty.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/85ecf539_3ca639e7 PS8, Line 6: #include <osmocom/vty/command.h> > only vty. […] include/osmocom/vty/command.h 175:struct cmd_element { https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/d054c21b_67d92401 PS8, Line 28: > (trailing blank line) Ack File src/host/layer23/include/osmocom/bb/modem/vty.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/0c4386bb_0453a0cd PS8, Line 7: #include <osmocom/bb/common/vty.h> > none of the includes are necessary for this .h, need only […] Ack File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/56c9487d_0d2ccf80 PS8, Line 2: * (C) 2010 by Andreas Eversberg <[email protected]> > old (C) for new file? I copied stuff from another existing file. I'll also add sysmocom copyright for all the new stuff in it. https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/a36c6456_f7e6ae95 PS8, Line 172: int l23_vty_go_parent(struct vty *vty) > you can completely drop vty_go_parent since libosmocore patch […] Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/bf4a43f5_5d136f50 PS8, Line 186: int l23_vty_init(int (*config_write_ms_node_cb)(struct vty *)) > funny how in this patch, you don't check the rc of l23_vty_init() calls > anywhere. […] Done File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/6eaa2841_fcc37091 PS8, Line 3209: osmo_talloc_vty_add_cmds(); > why is this dropped? possibly better in a separate patch? Because it's added as part of l23_vty_init(). It makes total sense to have it in the same patch. File src/host/layer23/src/modem/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/ccfedff5_fb1a4ce3 PS8, Line 2: * (C) 2010 by Andreas Eversberg <[email protected]> > (old (C) for new file) Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/5ab47c93_e0969011 PS8, Line 58: > (extra blank line) Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iabfb3129199488d790b89884bc1e424f2aca696f Gerrit-Change-Number: 30961 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:49:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
