Attention is currently required from: neels, pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 )
Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Patchset: PS4: LGTM besides the unresolved comment File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/f3ebaeca_94c48be2 PS2, Line 1: ! > It's not unrelated. […] Done File src/host/layer23/include/osmocom/bb/common/osmocom_data.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/b0832ece_228e519d PS2, Line 37: struct osmobb_l23_vty_sig_data { > because more commands will probably be added later. […] still unresolved, the union wasn't added yet -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib5c9b6f3efa255d67980945db9f98dd8a112af0e Gerrit-Change-Number: 30972 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
