Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API ...................................................................... Patch Set 4: Code-Review+1 (5 comments) File src/core/tun.c: https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/93a049cd_ab592f3d PS4, Line 73: *NULL missing space https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/42a62f49_6cf0e28b PS4, Line 238: LOGTUN(tundev, LOGL_ERROR, "Cannot obtain netns file descriptor: %s (%d)\n", log netns_name here? https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/9beebce0_4594246d PS4, Line 245: if (tundev->netns_name) { same condition, why is this not part of the above if-block? https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/e9fe1af4_5796b15e PS4, Line 405: whien when https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/c0d58412_e31bf2e3 PS4, Line 421: osmo_tundev_encaps > probably just my personal point of view, but let's see if others agree: I > find it a bit odd to call […] agreed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53 Gerrit-Change-Number: 31025 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jan 2023 09:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
