Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5198/1/src/osmobts_sock.cpp
File src/osmobts_sock.cpp:

Line 263:       rc = connect(bfd->fd, (struct sockaddr *) &local, namelen);
TURN VALUE
       If the connection or binding succeeds, zero is returned.  On  error,  -1 
 is  returned,  and
       errno is set appropriately.

I think you want to do a strerror here, and not print '-1" all the time, right?


-- 
To view, visit https://gerrit.osmocom.org/5198
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd5736b5916cbad72b96f064929bb667ff97ded
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to