Attention is currently required from: pespin, fixeria, dexter.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30876 )

Change subject: pcu_sock: rework check logic for ts
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/0f117354_86d92456
PS2, Line 96: static bool ts_is_pdch(const struct gsm_bts_trx_ts *ts)
> When I understand this correctly, then pcu_tx_info_ind() should be run each 
> time there is a change w […]
yes, that matches my understanding of the PCU interface. I'm sure @pespin is 
more familiar with the details.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a
Gerrit-Change-Number: 30876
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to