Attention is currently required from: dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205 )

Change subject: MGCP_Test: Test ts101318 rfc5993 conversation with fmtp
......................................................................


Patch Set 1:

(1 comment)

File mgw/MGCP_Test.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205/comment/210b5ce5_89680d7a
PS1, Line 2312:         testcase TC_ts101318_rfc5993_rtp_conversion() runs on 
dummy_CT {
maybe use const octetstring definining the strings below containing RTP bytes? 
This way it's also easier to understand which is which.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I14421f780c4ef9e4c7e91182154070617852e957
Gerrit-Change-Number: 31205
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Feb 2023 12:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to