Patch Set 1: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/5164/1/jobs/gerrit-verifications.yml File jobs/gerrit-verifications.yml: Line 109: cmd: GTP="$GTP" ./contrib/jenkins.sh interesting though to pass in the GTP env var as the contents of the GTP env var :) ... doesn't that propagate to jenkins.sh anyway? Either way, explicit is better than implicit. -- To view, visit https://gerrit.osmocom.org/5164 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1a630b77a8c2f442e26dbef8e608882e8f9a71 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
