Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31265 )
Change subject: gsm0808_enc/dec_channel_type: support data ...................................................................... Patch Set 3: (2 comments) File include/osmocom/gsm/protocol/gsm_08_08.h: https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/5a0312a1_03b88e5b PS2, Line 503: /* GSM 08.08 3.2.2.11 Channel Type > TS 48. […] Done File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/fe442364_3e212ddc PS2, Line 511: byte = ct->data_transparent ? 0x40 : 0x00; /* Set T/NT */ > this looks a bit confusing. I'd be clearer probably: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib7b75c9d86aace329decf20003b68de459021c64 Gerrit-Change-Number: 31265 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 09 Feb 2023 12:31:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
