fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241 )
Change subject: library/GSM_Types: fix encoding of BcdMccMnc (3 octets) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This commit is causing regressions in lots of nacc related tests in > ttcn3-pcu-test. […] Sorry for that. Laforge was right about the nibble swapping. The problem is that it only works when using the TITAN's RAW codec, now when using hex2oct(). I submitted a revert and added a selftest, please see: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31276 (OS#5901). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31241 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifa3083fdd6307b56baa1ef3ac85a3e7a2efab728 Gerrit-Change-Number: 31241 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 10 Feb 2023 02:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
