Patch Set 1: Code-Review+1 (5 comments)
minor things I'd let pass, but if you'd like to fix them... https://gerrit.osmocom.org/#/c/5215/1/src/tbf.cpp File src/tbf.cpp: Line 477: (tbf->direction != GPRS_RLCMAC_UL_TBF) ? "DL" : "UL"); (change unrelated) Line 489: LOGP(DRLCMAC, LOGL_DEBUG, "********** DL-TBF update **********\n"); (change unrelated) Line 939: LOGP(DRLCMAC, LOGL_DEBUG, "********** DL-TBF starts here **********\n"); (change unrelated) Line 941: ms_class, egprs_ms_class); (change unrelated) https://gerrit.osmocom.org/#/c/5215/1/src/tbf.h File src/tbf.h: Line 139: #define LOGPTBF(level, tbf, fmt, args...) LOGP(DRLCMAC, level, "%s " fmt, tbf_name(tbf), ## args) (our usual pattern here would be LOGPFOO(foo, level, ...), i.e. the object first, see LOGPFSM for example) -- To view, visit https://gerrit.osmocom.org/5215 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I388249afefc32d2f6e5cb5e5abc6daf4dbd284ea Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
