Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291 )

Change subject: library/DIAMETER_Emulation: f_diameter_xceive(): ignore 
unexpected PDUs
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
I would think that for a *test suite* it is questionable to ignore any and all 
unknown/unexpected packets.  Normally we should have an expectation what (if 
anything at all) to receive, and we should only ever accept things we are 
accepting.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31291
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dbc646d5f036f454f197137373796f40c4c9e74
Gerrit-Change-Number: 31291
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sat, 11 Feb 2023 09:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to