Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31285 )
Change subject: rlcmac: Implement GMMRR-ASSIGN.req ...................................................................... Patch Set 3: (1 comment) File include/osmocom/gprs/rlcmac/rlcmac_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31285/comment/9e42592c_b76a1372 PS3, Line 189: struct osmo_gprs_rlcmac_prim *osmo_gprs_rlcmac_prim_alloc_gmmrr_assign_req( > also weird how it has no .c file equivalent. […] No need for a separate patch. This function is not yet used at all because it was not implemented. Makes no sense to have a separate patch if this function was not even implemented before. Previous patch was already merged. It cannot be static: As its prefix suggest, it's a public API. Please remember this is all in active development and lots of code is being written/imported. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3178aa1af4a6c05c84253c6befcd4c786b8dd8e9 Gerrit-Change-Number: 31285 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Mon, 13 Feb 2023 09:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
