Attention is currently required from: osmith, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31269 )
Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... Patch Set 2: (5 comments) File src/libosmo-mgcp/mgcp_e1.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/74cc9acb_dc49f4c9 PS1, Line 370: subslot > subslots Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/59f0c2a9_8fd8fe72 PS1, Line 371: belos > below Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/8d32f421_eeed9fe0 PS1, Line 432: LOGL_INFO > * if this shouldn't happen, maybe LOGL_ERROR? […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/bdd285db_93824ecd PS1, Line 445: e > it might be cleaner to introduce a e1inp_ts_config_none() api similar to the > e1inp_ts_config_{hdlc,i […] Ack https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/1ac9ee85_a3d3d68d PS1, Line 657: urad against multiple calls. In case we do > Guard, don't? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 13 Feb 2023 11:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
